akalash commented on a change in pull request #16885:
URL: https://github.com/apache/flink/pull/16885#discussion_r693122516
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -881,12 +859,16 @@ private boolean areCheckpointsWithFinishedTasksEnabled() {
}
@Override
- public void cleanUp() throws Exception {
+ public final void cleanUp() throws Exception {
LOG.debug(
"Cleanup StreamTask (operators closed: {}, cancelled: {})",
closedOperators,
canceled);
+ failing = !canceled;
+
+ Exception suppressedException =
runAndSuppressThrowable(this::cancelTask, null);
Review comment:
The current master is call `cancelTask` if the **exception happens** and
the task is **not canceled**. But in your new version you do it always
regardless the exception or not. So as I understand it is not equvialent call
right now it is new behaviour. This why I have concern about the case when the
task sucessfully finished but we anyway call the `cancelTask`. Right now I
don't understand why we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
