Thesharing opened a new pull request #16935:
URL: https://github.com/apache/flink/pull/16935


   ## What is the purpose of the change
   
   *This pull request intend to fix broken links to Task Failure Recovery page 
on Configuration page. In Hugo we can use the variable `{{.Site.BaseURL}}` to 
make sure the links are always right no matter where they are. This variable 
makes sure the links refer to absolute path instead of relative path.*
   
   *In #16724, we verify the changes by running the local server with Hugo and 
checking if the links head to the correct page. But it seems 
`{{.Site.BaseURL}}` in local server is ended with `/`, while the remote server 
that hosts the docs for Flink doesn't. Thus, we need to add the suffix.*
   
   *Furthermore, we add a variable `{{.Site.LanguagePrefix}}` to make sure the 
Chinese version will direct to the page in Chinese version, rather than the 
English version.*
   
   ## Brief change log
   
   - *Fix broken links in RestartStrategyOptions.java and 
JobManagerOptions.java*
   - *Generate the docs based on the modification above*
   
   ## Verifying this change
   
   *Run the local server with Hugo and check if the links head to the correct 
pages.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to