Airblader commented on pull request #16902: URL: https://github.com/apache/flink/pull/16902#issuecomment-903473360
FYI, the CI currently fails because it doesn't know `npx`. > As for the CI, can you give me some guide about the shell file that should be modified? I could not find it under ./tool/ci/. In flink-runtime-web/pom.xml, first `npm ci` and then `npm run build` is executed. I think we should hook into the `build` script to also run the linter first. An alternative would be to create a separate npm script which does lint+build and then call that from `pom.xml`. Once the build for this PR is passing we should intentionally introduce a commit that breaks the linter to verify that the CI is picking up on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
