[
https://issues.apache.org/jira/browse/FLINK-23907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403064#comment-17403064
]
Chesnay Schepler commented on FLINK-23907:
------------------------------------------
The idea is neat but it is a bit hard to judge whether it would get merged
without seeing a PR. You can open one if you wish.
Considering that you claim this will improve performance, how do you intend to
measure the actual impact on Flink? Do you expect us to verify that? Based on
the examples you gave I would expect the impact to be minimal.
Just to manage expectations: The project is currently busy preparing the next
release so any review/merge may take a bit.
> Type Migration: introducing primitive functional interfaces
> -----------------------------------------------------------
>
> Key: FLINK-23907
> URL: https://issues.apache.org/jira/browse/FLINK-23907
> Project: Flink
> Issue Type: Improvement
> Reporter: Oleg Smirnov
> Assignee: Oleg Smirnov
> Priority: Minor
> Labels: refactoring, type-migration
>
> Hey!
> We are a collaborative group of researchers from JetBrains Research and
> Oregon State University, and we are testing our data-driven
> [plugin|https://github.com/JetBrains-Research/data-driven-type-migration],
> which is based on the IntelliJ's [Type
> Migration|https://www.jetbrains.com/help/idea/type-migration.html] framework
> and adjusts it using custom structural-replace templates that express the
> adaptations required to perform the type changes.
> I want to apply several type changes using it and open the PR, thus
> introducing primitive functional interfaces in order to prevent unnecessary
> boxing (like *{{BooleanSupplier}}* instead *{{Supplier<Boolean>}}*,
> {{*OptionalInt*}} instead of {{*Optional<Integer>*}}, {{*Predicate<T>*}}
> instead of {{*Function<T, Boolean*}}>, etc.), since it can affect the
> performance of the code (_Effective Java,_ Items 44, 61).
> The patch itself is already prepared (because it is done automatically using
> the plugin), so I guess I will need to open this ticket, receive your
> approval, and then open the PR?
> It would help us a lot to evaluate the usefulness of our approach!
> Thank you in advance!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
