pnowojski commented on a change in pull request #16885:
URL: https://github.com/apache/flink/pull/16885#discussion_r693982027
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -762,17 +762,25 @@ private void doRun() {
executingThread.setContextClassLoader(userCodeClassLoader.asClassLoader());
AbstractInvokable finalInvokable = invokable;
- runWithSystemExitMonitoring(finalInvokable::restore);
+ try {
Review comment:
Can you extract at least some of this code to smaller methods? `doRun()`
is already too large, and you are making it even larger. You don't have to fix
all of it, but at least the part that you grew a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
