[
https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333578#comment-15333578
]
ASF GitHub Bot commented on FLINK-3951:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2112
-1. I haven't looked very deeply at the actual code but let me share some
thoughts:
I was under the impression that the core of this issue was to implement at
least 1 Histogram that does not rely on another library. It _should_ contain at
least one to guarantee that the compatibility layer works properly.
The original PR for the metric system already contained wrapped DropWIzard
Histograms, which were specifically taken out as they did not meet our
performance needs. Why we now essentially revert this decision now 2 weeks
later is beyond me. I also hope you did not spend too much time writing this as
a lot of similar code already existed.
As such I really don't see the point of the DropWizardWrapper. IMO the only
thing we need is the HistogramWrapper class, which may require a more
distinctive name btw. . We should not expose a DW -> Flink compatibility layer,
next up people want to use DW Timers, Gauges etc. as well. This will simply
create more work for us.
The original PR also contained the flink-metric-reporters module as
flink-metrics. Now we revert this again as well. Just...wth.
> Add Histogram Metric Type
> -------------------------
>
> Key: FLINK-3951
> URL: https://issues.apache.org/jira/browse/FLINK-3951
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: Stephan Ewen
> Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
