rkhachatryan commented on a change in pull request #16846:
URL: https://github.com/apache/flink/pull/16846#discussion_r694676406
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -133,13 +134,22 @@
public static final ConfigOption<Boolean> ESTIMATE_LIVE_DATA_SIZE =
ConfigOptions.key(RocksDBProperty.EstimateLiveDataSize.getConfigKey())
.defaultValue(false)
- .withDescription("Estimate of the amount of live data in
bytes.");
+ .withDescription(
+ "Estimate of the amount of live data in bytes
(usually smaller than sst files size due to data duplication across different
levels).");
public static final ConfigOption<Boolean> MONITOR_TOTAL_SST_FILES_SIZE =
ConfigOptions.key(RocksDBProperty.TotalSstFilesSize.getConfigKey())
.defaultValue(false)
.withDescription(
- "Monitor the total size (bytes) of all SST files."
+ "Monitor the total size (bytes) of all SST files
of all versions."
+ + "WARNING: may slow down online queries
if there are too many files.");
+
+ public static final ConfigOption<Boolean> MONITOR_LIVE_SST_FILES_SIZE =
+ ConfigOptions.key(RocksDBProperty.LiveSstFilesSize.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Monitor the total size (bytes) of all SST files
belong to the latest version."
Review comment:
nit:
```suggestion
"Monitor the total size (bytes) of all SST files
belonging to the latest version."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
