pnowojski commented on pull request #16905: URL: https://github.com/apache/flink/pull/16905#issuecomment-904512907
edit: I think we already [have this condition added later](https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java#L840) in the `afterInvoke`. So as I understand this issue now I think a bit more, the root problem is that we are first stopping the sources and only after that we are actually setting `syncSavepointWithDrain` variable? In that case my counterproposal would be still similar, and the solution should be that we set `syncSavepointWithDrain` before stopping the sources? In a very similar way how `SourceStreamTask#stopOperatorForStopWithSavepointWithDrain` we are already doing in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
