zentol commented on pull request #16951: URL: https://github.com/apache/flink/pull/16951#issuecomment-904740141
Depends a bit on what the method intends to provide. If it wants to ensure that the runnable is run after the job has indeed failed (i.e., the TM crash is noticed by the JM), which is what it currently does and what the naming seems to imply, then that would not be acceptable. Given the current usages of this method it would be fine, because the runnable never does anything interesting in the first place. However, we must ensure that the implementations from all TestEnvironments are aligned with each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
