Airblader commented on a change in pull request #16902: URL: https://github.com/apache/flink/pull/16902#discussion_r695418767
########## File path: flink-runtime-web/src/main/resources/META-INF/NOTICE ########## @@ -13,6 +13,11 @@ The Apache Software Foundation (http://www.apache.org/). @angular/platform-browser 12.1.3 : MIT License @angular/platform-browser-dynamic 12.1.3 : MIT License @angular/router 12.1.3 : MIT License +@angular-eslint/builder 12.3.1 : MIT License Review comment: All of these are dev dependencies, right? Do we even need to add them to the NOTICE file? It seems at least any other dev dependency I looked at isn't mentioned here either. I'll see if I can find out whether this is necessary. ########## File path: flink-runtime-web/web-dashboard/.stylelintrc.js ########## @@ -0,0 +1,284 @@ +module.exports = { + plugins: ['stylelint-order'], + extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'], + rules: { + 'prettier/prettier': [ + true, + { + singleQuote: false + } + ], + 'no-empty-source': null, + 'no-descending-specificity': null, + 'no-invalid-position-at-import-rule': null, + 'function-calc-no-invalid': null, + 'font-family-no-missing-generic-family-keyword': null, + 'selector-pseudo-element-no-unknown': [ + true, + { + ignorePseudoElements: ['ng-deep'] + } + ], + // Reference: https://github.com/hudochenkov/stylelint-config-hudochenkov/blob/master/order.js + 'order/order': [ + [ + 'dollar-variables', + 'custom-properties', + 'at-rules', + 'declarations', + { + type: 'at-rule', + name: 'supports' + }, + { + type: 'at-rule', + name: 'media' + }, + 'rules' + ], + { + severity: 'warning' + } + ], + 'order/properties-order': [ Review comment: In general I don't want to focus on the individual settings in this PR, we can always improve those later if we feel any of them are not ideal. However, for this one I'm just curious how this list was created. It's pretty long and seems quite opinionated? Do we need/want to be this strict with the order of properties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
