[
https://issues.apache.org/jira/browse/FLINK-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333749#comment-15333749
]
ASF GitHub Bot commented on FLINK-3714:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2093
Could you please update the tests to add elements to `expectedOutput` in
line with the `processElement` and `processWatermark` calls on the test
harness. In the existing tests I did this and it makes it easy to reason about
what output should be produced in sequence. If the expected elements/watermark
are added in after the other calls you have to keep jumping back and forth when
reading the test. Also, could you replace the `el`, `el2` and so on variables
with inline tuple creation. For the same reason of not having to jump back and
forth when reading the tests?
> Add Support for "Allowed Lateness"
> ----------------------------------
>
> Key: FLINK-3714
> URL: https://issues.apache.org/jira/browse/FLINK-3714
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Kostas Kloudas
>
> As mentioned in
> https://docs.google.com/document/d/1Xp-YBf87vLTduYSivgqWVEMjYUmkA-hyb4muX3KRl08/edit#
> we should add support for an allowed lateness setting.
> This includes several things:
> - API for setting allowed lateness
> - Dropping of late elements
> - Garbage collection of windows state/timers
> Depending on whether the {{WindowAssigner}} assigns windows based on event
> time or processing time we have to adjust the GC behavior. For event-time
> windows "allowed lateness" makes sense and we should garbage collect after
> this expires. For processing-time windows "allowed lateness" does not make
> sense and we should always GC window state/timers at the end timestamp of a
> processing-time window. I think that we need a method for this on
> {{WindowAssigner}} that allows to differentiate between event-time windows
> and processing-time windows: {{boolean WindowAssigner.isEventTime()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
