tillrohrmann commented on a change in pull request #15546:
URL: https://github.com/apache/flink/pull/15546#discussion_r695615359
##########
File path: flink-end-to-end-tests/run-single-test.sh
##########
@@ -46,6 +46,10 @@ if [ -z "$FLINK_DIR" ] ; then
exit 1
fi
+if [ -z "$FLINK_LOG_DIR" ] ; then
+ export FLINK_LOG_DIR="$FLINK_DIR/logs"
Review comment:
Same here.
##########
File path: flink-end-to-end-tests/run-nightly-tests.sh
##########
@@ -32,30 +32,24 @@ if [ -z "$FLINK_DIR" ] ; then
exit 1
fi
+if [ -z "$FLINK_LOG_DIR" ] ; then
+ export FLINK_LOG_DIR="$FLINK_DIR/logs"
Review comment:
I think this change breaks the e2e setup on my machine (MacOS) because
the directory does not exist.
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -26,6 +26,10 @@ if [[ -z $FLINK_DIR ]]; then
exit 1
fi
+if [ -z "$FLINK_LOG_DIR" ] ; then
+ export FLINK_LOG_DIR="$FLINK_DIR/logs"
Review comment:
And here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
