[
https://issues.apache.org/jira/browse/FLINK-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333870#comment-15333870
]
ASF GitHub Bot commented on FLINK-4083:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/2117
[FLINK-4083] [java,DataSet] Introduce closure cleaning in Join.where(…
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink 4083-Closure_Cleaner_Join
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 9ff6366599127ddd1f54bb50e73ba8584e509564
Author: Stefan Richter <[email protected]>
Date: 2016-06-16T13:26:12Z
[FLINK-4083] [java,DataSet] Introduce closure cleaning in Join.where() and
Join.equaltTo()
----
> Use ClosureCleaner for Join where and equalTo
> ---------------------------------------------
>
> Key: FLINK-4083
> URL: https://issues.apache.org/jira/browse/FLINK-4083
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.0.3
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Minor
>
> When specifying a key selector in the where or equalTo clause of a Join, the
> closure cleaner is not used. Same problem as FLINK-4078.
> {code}
> .join(ds)
> .where(new KeySelector<CustomType, Integer>() {
> @Override
> public Integer getKey(CustomType value) {
> return value.myInt;
> }
> })
> .equalTo(new KeySelector<CustomType, Integer>(){
> @Override
> public Integer getKey(CustomType value) throws Exception {
> return value.myInt;
> }
> });
> {code}
> The problem is that the KeySelector is an anonymous inner class and as such
> as a reference to the outer object. Normally, this would be rectified by the
> closure cleaner but the cleaner is not used in Join.where() and
> Join.equalTo().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
