tillrohrmann commented on a change in pull request #16971:
URL: https://github.com/apache/flink/pull/16971#discussion_r695843247
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemoryReporterRule.java
##########
@@ -41,26 +58,41 @@
*/
@Experimental
public class InMemoryReporterRule implements ExternalResource {
- private final InMemoryReporter inMemoryReporter =
InMemoryReporter.getInstance();
+ private final InMemoryReporter inMemoryReporter;
- public static InMemoryReporterRule create() {
- return new InMemoryReporterRule();
+ public static InMemoryReporterRule fromMiniCluster(MiniClusterResource
miniClusterResource) {
Review comment:
Can we invert the dependency? Differently said: Can we allow to
configure a `MetricReporter` for the `MiniCluster`? If yes, then we can have
our `InMemoryReporterRule` (actually so far all `ExternalResources` have the
`Resource` suffix and not `Rule`), which creates our reporter and then we start
the `MiniCluster` with this reporter. That way we can also have a special
`MetricReporter` that retains the metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
