nicolasraga1 commented on a change in pull request #16946: URL: https://github.com/apache/flink/pull/16946#discussion_r696224717
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobManagerSharedServicesTest.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmaster; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.RestOptions; +import org.apache.flink.runtime.blob.BlobServer; +import org.apache.flink.runtime.blob.VoidBlobStore; +import org.apache.flink.runtime.util.TestingFatalErrorHandler; +import org.apache.flink.util.TestLogger; + +import org.junit.Test; + +import java.util.concurrent.ThreadPoolExecutor; + +import static org.junit.Assert.assertEquals; + +/** + * Tests auxiliary shared services created by {@link JobManagerSharedServices} and used by the + * {@link JobMaster}. + */ +public class JobManagerSharedServicesTest extends TestLogger { + + private static final int NUM_FUTURE_THREADS = 128; + private static final int NUM_IO_THREADS = 256; + + @Test + public void testBasicMapping() throws Exception { + Configuration config = new Configuration(); + config.setInteger(RestOptions.JOBMANAGER_FUTURE_THREADS, NUM_FUTURE_THREADS); + config.setInteger(RestOptions.JOBMANAGER_IO_THREADS, NUM_IO_THREADS); + + final JobManagerSharedServices jobManagerSharedServices = + JobManagerSharedServices.fromConfiguration( + config, + new BlobServer(config, new VoidBlobStore()), + new TestingFatalErrorHandler()); + assertEquals( + NUM_FUTURE_THREADS, + ((ThreadPoolExecutor) jobManagerSharedServices.getFutureExecutor()) + .getCorePoolSize()); + assertEquals( + NUM_IO_THREADS, + ((ThreadPoolExecutor) jobManagerSharedServices.getIoExecutor()).getCorePoolSize()); Review comment: Sounds good, I'll implement it as you described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
