pnowojski commented on a change in pull request #16990:
URL: https://github.com/apache/flink/pull/16990#discussion_r696559719
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/NoOpTimestampsAndWatermarks.java
##########
@@ -75,14 +78,17 @@ public void stopPeriodicWatermarkEmits() {
private final PushingAsyncDataInput.DataOutput<T> output;
private final TimestampAssigner<T> timestampAssigner;
+ private final InternalSourceReaderMetricGroup.SourceListener
sourceListener;
private final StreamRecord<T> reusingRecord;
private TimestampsOnlyOutput(
PushingAsyncDataInput.DataOutput<T> output,
- TimestampAssigner<T> timestampAssigner) {
+ TimestampAssigner<T> timestampAssigner,
+ InternalSourceReaderMetricGroup.SourceListener sourceListener)
{
Review comment:
Instead of both modifing this class and SourceOutputWithWatermarks.java
wouldn't it be enough to add `SourceListener` just to
`org.apache.flink.streaming.runtime.tasks.SourceOperatorStreamTask.AsyncDataOutputToOutput`?
I'm not sure, but I think that `PushingAsyncDataInput.DataOutput<T> output`
from this constructor is always
`SourceOperatorStreamTask.AsyncDataOutputToOutput`. Isn't it?
Also, are both of those classes tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
