[
https://issues.apache.org/jira/browse/FLINK-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405523#comment-17405523
]
Mason Chen commented on FLINK-17495:
------------------------------------
[~chesnay] Finally got approval! Here's the PR:
[https://github.com/apache/flink/pull/17007.] Saw some users asking about
adding some identifiers to their metrics, maybe this would help.
> Add support for custom variables
> --------------------------------
>
> Key: FLINK-17495
> URL: https://issues.apache.org/jira/browse/FLINK-17495
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Reporter: jinhai
> Assignee: Mason Chen
> Priority: Minor
> Labels: auto-deprioritized-major, pull-request-available,
> stale-assigned
>
> Allow users to configure additional labels, presumably via a new config
> option {{metrics.scope.variables.add.}}
> E.g.,
> {code:java}
> metrics.scope.variables.add: key1:value1;key2:value2 {code}
> Configured variables should be added to the variables map of the root metric
> group; this may allow us in the future (once we have generalized scope
> formats a bit) to include them there as well.
>
> Original description:
> {quote}We need to add some custom labels on Prometheus, so we can query by
> them.?? ??
> Now we can add jobName\groupingKey to PrometheusPushGatewayReporter in
> version 1.10, but not in PrometheusReporter.
> Can we add AbstractPrometheusReporter#addDimension method to support this, so
> they will be no differences except for the metrics exposing mechanism
> pulling/pushing.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
