Myasuka commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r697299339



##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -221,6 +229,9 @@ public ColumnFamilyOptions 
createColumnOptions(Collection<AutoCloseable> handles
 
     // ------------------------------------------------------------------------
 
+    public static final long DEFAULT_LOG_FILE_SIZE = 10 * 1024 * 1024L;
+    public static final int DEFAULT_LOG_FILE_NUM = 10;

Review comment:
       I replied in 
https://github.com/apache/flink/pull/16964#discussion_r697278207 and prefer to 
not change current status currently. And I think filling the default values 
could be done in another ticket.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to