alpinegizmo commented on a change in pull request #31:
URL: https://github.com/apache/flink-training/pull/31#discussion_r697512116
##########
File path:
common/src/main/java/org/apache/flink/training/exercises/common/datatypes/TaxiRide.java
##########
@@ -156,7 +156,9 @@ public int compareTo(@Nullable TaxiRide other) {
@Override
public boolean equals(Object other) {
- return other instanceof TaxiRide && this.rideId == ((TaxiRide)
other).rideId;
+ return other instanceof TaxiRide
+ && this.rideId == ((TaxiRide) other).rideId
+ && this.isStart == ((TaxiRide) other).isStart;
Review comment:
Didn't know that intellij can generate the equals and hashcode methods.
Cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
