tillrohrmann commented on pull request #16915: URL: https://github.com/apache/flink/pull/16915#issuecomment-907328516
I've updated this PR @zentol. What I effectively did is to introduce a `ServerConnection` class that encapsulates the logic for a pending and established connection. This class is responsible for synchronizing the outside accesses which allows that the `PendingConnection` can now work w/o synchronization. Also the `EstablishedConnection` could be simplified because the only concurrency comes from the Netty call back that might trigger `EstablishedConnection.close()`. Moreover, it promoted all these classes from inner classes to static (inner) classes. This disentangles the classes a bit better. I hope that this makes the code easier to read and to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
