Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1954#discussion_r67506447
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
 ---
    @@ -54,6 +55,18 @@ public static RestartStrategyConfiguration 
fixedDelayRestart(
                return new 
FixedDelayRestartStrategyConfiguration(restartAttempts, delayBetweenAttempts);
        }
     
    +   /**
    +    * Generates a FailureRateRestartStrategyConfiguration.
    +    *
    +    * @param maxFailureRate Maximum number of restarts in given time unit 
{@code failureRateUnit} before failing a job
    +    * @param failureRateUnit Time unit for measuring failure rate
    +    * @param delayBetweenRestartAttempts Delay in-between restart attempts
    +    */
    +   public static FailureRateRestartStrategyConfiguration 
failureRateRestart(
    +                   int maxFailureRate, TimeUnit failureRateUnit, long 
delayBetweenRestartAttempts) {
    --- End diff --
    
    Maybe we could change the parameter list to `failureRateRestart(int rate, 
long interval, TimeUnit intervalUnit, long delay, TimeUnit delayUnit)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to