[
https://issues.apache.org/jira/browse/FLINK-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336151#comment-15336151
]
ASF GitHub Bot commented on FLINK-4078:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2116#discussion_r67514396
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CoGroupITCase.java
---
@@ -334,6 +335,124 @@ public void
testCoGroupWithMultipleKeyFieldsWithKeyExtractor() throws Exception
compareResultAsTuples(result, expected);
}
+ @Test
+ public void
testCoGroupWithMultipleKeyFieldsWithInnerClassKeyExtractorWithClosureCleaner()
throws Exception {
+ /*
--- End diff --
We usually do inline multi line comments via `// ...`.
> Use ClosureCleaner for CoGroup where
> ------------------------------------
>
> Key: FLINK-4078
> URL: https://issues.apache.org/jira/browse/FLINK-4078
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.0.3
> Reporter: Ufuk Celebi
> Assignee: Stefan Richter
> Fix For: 1.1.0
>
>
> When specifying a key selector in the where clause of a CoGroup, the closure
> cleaner is not used.
> {code}
> .coGroup(filteredIds)
> .where(new KeySelector<T, String>() {
> @Override
> public String getKey(T t) throws Exception {
> String s = (String) t.get(fieldName);
> return s != null ? s : UUID.randomUUID().toString();
> }
> })
> {code}
> The problem is that the KeySelector is an anonymous inner class and as such
> as a reference to the outer object. Normally, this would be rectified by the
> closure cleaner but the cleaner is not used in CoGroup.where().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
