Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2112#discussion_r67515502
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -99,8 +100,11 @@ public void notifyOfAddedMetric(Metric metric, String
metricName, AbstractMetric
jmxMetric = new JmxGauge((Gauge<?>) metric);
} else if (metric instanceof Counter) {
jmxMetric = new JmxCounter((Counter) metric);
+ } else if (metric instanceof Histogram) {
+ jmxMetric = new JmxHistogram((Histogram) metric);
} else {
- LOG.error("Unknown metric type: " +
metric.getClass().getName());
+ LOG.error("Cannot add unknown metric type: {}. This
indicates that the metric type " +
--- End diff --
should use the log field in AbstractReporter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
