[GitHub] [flink] dmvk commented on a change in pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…

Sun, 29 Aug 2021 23:25:37 -0700 


dmvk commented on a change in pull request #17000:
URL: https://github.com/apache/flink/pull/17000#discussion_r698217809



##########
File path: 
flink-tests/src/test/java/org/apache/flink/test/runtime/leaderelection/ZooKeeperLeaderElectionITCase.java
##########
@@ -121,38 +145,39 @@ public void testJobExecutionOnClusterWithLeaderChange() 
throws Exception {
                 final DispatcherGateway leaderDispatcherGateway =
                         getNextLeadingDispatcherGateway(
                                 miniCluster, previousLeaderAddress, timeout);
+                // Make sure resource manager has also changed leadership.
+                resourceManagerLeaderFutures[i].get();

Review comment:
       Thanks for creating an issue to track this! This seems to be a bigger 
issue than I initially thought 🤔 
   
   This instability came from asserting that 
`DispatcherResourceManagerComponent` shutdownFuture doesn't complete 
exceptionally.
   
   ![Screen Shot 2021-08-30 at 8 21 58 
AM](https://user-images.githubusercontent.com/299781/131294525-743dbb10-20cc-4437-9768-efb2ceb1828f.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to