twalthr commented on a change in pull request #17048:
URL: https://github.com/apache/flink/pull/17048#discussion_r698371932



##########
File path: 
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java
##########
@@ -90,13 +90,18 @@ public static RelNode convertDataStreamToRel(
         final DynamicTableSource tableSource =
                 new ExternalDynamicSource<>(
                         identifier, dataStream, physicalDataType, 
isTopLevelRecord, changelogMode);
+        final FlinkStatistic statistic =
+                FlinkStatistic.builder()
+                        // this is a temporary solution, FLINK-15123 will 
resolve this

Review comment:
       yes, and then you wonder why your primary keys are lost if you don't 
have statistics defined




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to