tisonkun commented on a change in pull request #17051:
URL: https://github.com/apache/flink/pull/17051#discussion_r698588574
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
##########
@@ -30,14 +30,23 @@
import org.apache.flink.api.java.typeutils.TupleTypeInfo;
import org.apache.flink.api.java.typeutils.TupleTypeInfoBase;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import java.io.Serializable;
+import java.util.Optional;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
/** Static factories for the {@link FieldAccessor} utilities. */
@Internal
public class FieldAccessorFactory implements Serializable {
+ private static final Logger LOG =
LoggerFactory.getLogger(FieldAccessorFactory.class);
+
+ private static final Optional<ScalaProductFieldAccessorFactory>
Review comment:
IIRC we use nullable for field. Also as we check `isPresent` manually,
use `Optional` doesn't help a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
