zentol commented on a change in pull request #17007:
URL: https://github.com/apache/flink/pull/17007#discussion_r699157438
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/FrontMetricGroup.java
##########
@@ -72,8 +74,15 @@ public MetricGroup getWrappedMetricGroup() {
@Override
public Map<String, String> getAllVariables() {
- return parentMetricGroup.getAllVariables(
- this.settings.getReporterIndex(),
this.settings.getExcludedVariables());
+ Map<String, String> allVariables =
+ parentMetricGroup.getAllVariables(
+ this.settings.getReporterIndex(),
this.settings.getExcludedVariables());
+
+ if (this.settings.getAdditionalVariables().isEmpty()) {
+ return allVariables;
+ }
+
+ return new CompositeMap(allVariables,
this.settings.getAdditionalVariables());
Review comment:
I think that's fine, but we could also wrap it in
`Collections.unmodifiableMap()`, because we don't want any modifications _at
all_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
