AHeise commented on a change in pull request #17019:
URL: https://github.com/apache/flink/pull/17019#discussion_r699524495
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java
##########
@@ -406,8 +406,14 @@ private void deleteTestTopic(String topic)
}
private List<ConsumerRecord<byte[], byte[]>>
drainAllRecordsFromTopic(String topic) {
+ Properties properties = getKafkaClientConfiguration();
+ return drainAllRecordsFromTopic(topic, properties);
+ }
+
+ static List<ConsumerRecord<byte[], byte[]>> drainAllRecordsFromTopic(
Review comment:
This is used in a different test `KafkaWriterITCase`. Should be
extracted into a util if we reuse it in even more classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
