[ 
https://issues.apache.org/jira/browse/FLINK-23544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407760#comment-17407760
 ] 

JING ZHANG commented on FLINK-23544:
------------------------------------

[~jark] [~twalthr] Sorry for late response. [~twalthr] I agree with you that 
the syntax in this pr has syntax error, we have fixed that in 
https://issues.apache.org/jira/browse/FLINK-24024. The syntax in that pr follow 
the syntax of Session window TVF in Calcite 
([https://calcite.apache.org/docs/reference.html#session).] But it is different 
with the syntax in FLIP.

There is second option: merged  
https://issues.apache.org/jira/browse/FLINK-24024 to fix the session window TVF.

I'm not sure we should take the first option: revert this pr which means not 
exposing the SESSION WINDOW TVF feature in this version, or take the second 
option, merge https://issues.apache.org/jira/browse/FLINK-24024  which means we 
exposing the SESSION WINDOW TVF feature based on current Calcite SESSION WINDOW 
TVF which is different with the syntax in FLIP.

What do you thank about this? [~twalthr] [~jark] [~godfreyhe]

> Window TVF Supports session window
> ----------------------------------
>
>                 Key: FLINK-23544
>                 URL: https://issues.apache.org/jira/browse/FLINK-23544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: JING ZHANG
>            Assignee: JING ZHANG
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> Window TVF would support SESSION window in the following case:
>  # SESSION Window TVF followed by Window Aggregate, in this case SESSION 
> window TVF would be pulled up into WindowAggregate, so Window assigner would 
> happen in WindowAggrgeate  
>  
> *Note, SESSION window TVF only works in limited cases currently, the 
> following user cases is not supported yet:*
>  # *SESSION WINDOW TVF followed by Window JOIN*
>  # *SESSION WINDOW TVF followed by Window RANK***
> *BESIDES, SESSION window Aggregate does not support the following performance 
> improvement yet:*
>      1. Split Distinct Aggregation
>      2. Local-global Aggregation
>      3. Mini-batch Aggregate



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to