akalash commented on pull request #17024:
URL: https://github.com/apache/flink/pull/17024#issuecomment-910089106


   > A question when I use PipelinedSubpartition.bufferSize($size) reset 
subpartition buffers size ,It seems only first buffer affected by $size , is 
this normal?
   
   If I understood your question right then if one record allocates more than 
one buffer then the first buffer would be trimmed but the second one will be 
equal to the size of the rest of the record. In an ideal world, we should trim 
the second buffer too but in reality, it requires serious changes in the code 
which actually doesn't make any sense because it is a big mistake to configure 
buffer size less than one record.
   So the answer is yes, it trims only the first buffer for one record but it 
will trim for each next record too. You can take a look at the comment inside 
of BufferWritingResultPartition#addToSubpartition.
   
   P.S. Please, squash your commits into one(and you can rebase onto the fresh 
master).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to