xuyangzhong opened a new pull request #17118:
URL: https://github.com/apache/flink/pull/17118
## What is the purpose of the change
- In PushWatermarkIntoTableSourceScanRuleBase, the digest is created by
RexNode instead of Expression, RexNode rely on field index but Expression rely
on field name. The digest is adjusted from field index to field name.
- In the current situation, the extra digests of SourceAbilitySpec is
directly written by the corresponding rules. However, a good design is that the
extra digests are produced by SourceAbilitySpec by a common interface method.
We should not separate SourceAbilitySpec and digests, which may lead to the
risk of consistency.
## Brief change log
- *add a interface method named _getExtraDigests _into SourceAbilitySpec*
- *class
FilterPushDownSpec/LimitPushDownSpec/PartitionPushDownSpec/ProjectPushDownSpec/ReadingMetadataSpec/WatermarkPushDownSpec/SourceWatermarkSpec
all implement the interface method*
- *change the generation of extra digests in all corresponding rules*
## Verifying this change
Existing tests can cover this change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
