[ 
https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339014#comment-15339014
 ] 

ASF GitHub Bot commented on FLINK-3857:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/1962
  
    Hi @sbcd90,
    I think to address "add reconnect attempt" alone, checking whether or not 
the transport client is connected to nodes and retry connect if lost connection 
in `invoke()` before processing the element should be fine.
    
    On the other hand, another problem that raises if we are to add reconnect 
attempt for the ES sink is that failing records due to connection errors also 
need to be caught in the `BulkProcessor` `afterBulk()` callback and 
re-processed. I wonder if we should be solving this together to resolve this 
issue. @rmetzger, what's your opinion?


> Add reconnect attempt to Elasticsearch host
> -------------------------------------------
>
>                 Key: FLINK-3857
>                 URL: https://issues.apache.org/jira/browse/FLINK-3857
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming Connectors
>    Affects Versions: 1.1.0, 1.0.2
>            Reporter: Fabian Hueske
>            Assignee: Subhobrata Dey
>
> Currently, the connection to the Elasticsearch host is opened in 
> {{ElasticsearchSink.open()}}. In case the connection is lost (maybe due to a 
> changed DNS entry), the sink fails.
> I propose to catch the Exception for lost connections in the {{invoke()}} 
> method and try to re-open the connection for a configurable number of times 
> with a certain delay.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to