dawidwys commented on a change in pull request #17103:
URL: https://github.com/apache/flink/pull/17103#discussion_r701613277



##########
File path: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -68,13 +70,15 @@
                             .build());
 
     @Rule public final SharedObjects sharedObjects = SharedObjects.create();
+    @Rule public Timeout timeout = new Timeout(30, TimeUnit.SECONDS);

Review comment:
       Since some time we discourage timeouts in JUnit tests. Please see `Avoid 
timeouts in JUnit tests` here 
https://flink.apache.org/contributing/code-style-and-quality-common.html#design-for-testability
 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to