tweise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702102984
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplit.java
##########
@@ -57,38 +69,64 @@ public boolean equals(Object o) {
return false;
}
HybridSourceSplit that = (HybridSourceSplit) o;
- return sourceIndex == that.sourceIndex &&
wrappedSplit.equals(that.wrappedSplit);
+ return sourceIndex == that.sourceIndex
+ && Arrays.equals(wrappedSplitBytes, that.wrappedSplitBytes);
}
@Override
public int hashCode() {
- return Objects.hash(wrappedSplit, sourceIndex);
+ return Objects.hash(wrappedSplitBytes, sourceIndex);
}
@Override
public String toString() {
return "HybridSourceSplit{"
+ "realSplit="
- + wrappedSplit
+ + wrappedSplitBytes
+ ", sourceIndex="
+ sourceIndex
Review comment:
Done. I also removed `wrappedSplitBytes` because it doesn't provide
meaningful information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
