crazyzhou commented on a change in pull request #17064:
URL: https://github.com/apache/flink/pull/17064#discussion_r702533561
##########
File path:
flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testutils/source/reader/SourceReaderTestBase.java
##########
@@ -49,9 +50,17 @@ Licensed to the Apache Software Foundation (ASF) under one
*/
public abstract class SourceReaderTestBase<SplitT extends SourceSplit> extends
TestLogger {
- protected static final int NUM_SPLITS = 10;
+ protected static int numSplits;
Review comment:
Thanks for the comments. I have done the 2 and 3 in commit 56843f8 . For
1, I left `numSplits` and `totalNumRecords` protected final because this can
help the direct accesses to these variables in the Kafka test class, and the
`final` can still avoid further changes of these variables. If you still have
concerns on this, I can still change, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
