[ 
https://issues.apache.org/jira/browse/FLINK-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339776#comment-15339776
 ] 

ASF GitHub Bot commented on FLINK-3838:
---------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2139

    [FLINK-3838] Upgrade commons-cli to fix parsing of jar args

    The jar arguments were not parsed correctly if options were
    present. For example, in `./flink run <options> file.jar -arg value` the
    jar arguments would be parsed as "arg" and "value". Interestingly, this only
    happens when <options> are present.
    
    The issue has been fixed in commons-cli 1.3.1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-3838

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2139
    
----
commit ba09bee4b6325ee0fe85dbc9c04d2bdc80ab11a3
Author: Maximilian Michels <m...@apache.org>
Date:   2016-06-21T07:32:56Z

    [FLINK-3838] Upgrade commons-cli to fix parsing of jar args
    
    The jar arguments were not parsed correctly if options were
    present. For example, in `./flink run <options> file.jar -arg value` the
    jar arguments would be parsed as "arg" and "value". Interestingly, this only
    happens when <options> are present.
    
    The issue has been fixed in commons-cli 1.3.1.

----


> CLI parameter parser is munging application params
> --------------------------------------------------
>
>                 Key: FLINK-3838
>                 URL: https://issues.apache.org/jira/browse/FLINK-3838
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.0.2, 1.0.3
>            Reporter: Ken Krugler
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.1.0, 1.0.4
>
>
> If parameters for an application use a single '-' (e.g. -maxtasks) then the 
> CLI argument parser will munge these, and the app gets passed either just the 
> parameter name (e.g. 'maxtask') if the start of the parameter doesn't match a 
> Flink parameter, or you get two values, with the first value being the part 
> that matched (e.g. '-m') and the second value being the rest (e.g. 'axtasks').
> The parser should ignore everything after the jar path parameter.
> Note that using --<parameter name> does seem to work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to