gaborgsomogyi opened a new pull request #17156:
URL: https://github.com/apache/flink/pull/17156
## What is the purpose of the change
Custom netty handlers can do authentication (amongst other possibilities).
This requires that the handlers are getting the whole HttpRequest content
and not just partial data.
At the moment it's not implemented this way which ends-up in flaky behaviour.
Namely sometimes for example History server responds properly (when the
request fits into one netty chunk) but sometimes authentication fails (when the
request split into multiple netty chunks).
In this PR I've moved/added `FlinkHttpObjectAggregator` before custom netty
handlers.
## Brief change log
* Added `FlinkHttpObjectAggregator` in `WebFrontendBootstrap` before custom
netty handlers.
* Moved `FlinkHttpObjectAggregator` in `RestServerEndpoint` before custom
netty handlers.
Important note that upload handlers are streaming the uploadable content so
they must be before `FlinkHttpObjectAggregator`.
## Verifying this change
* Existing unit tests.
* Endurance test on cluster.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
