AHeise commented on a change in pull request #17152:
URL: https://github.com/apache/flink/pull/17152#discussion_r702844549



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkOperator.java
##########
@@ -104,6 +105,9 @@
 
     private final MailboxExecutor mailboxExecutor;
     private Counter numRecordsOutCounter;
+    // record endOfInput state to avoid duplicate prepareCommit on final 
notifyCheckpointComplete
+    // once FLIP-147 is fully operational all endOfInput processing needs to 
be removed

Review comment:
       Not yet. I think the scope is not clear yet. It probably will be big 
refactoring of the sink.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to