XComp commented on a change in pull request #16989:
URL: https://github.com/apache/flink/pull/16989#discussion_r702874833
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
##########
@@ -353,8 +358,7 @@ public void perJobYarnClusterOffHeap() throws Exception {
//
assertThat(flinkConfig,
hasEntry(JobManagerOptions.ADDRESS.key(), host));
} finally {
- yarnSessionClusterRunner.sendStop();
- yarnSessionClusterRunner.join();
+ yarnSessionClusterRunner.assertStop(30_000);
Review comment:
The problem with the YARN Tests, specifically, is that we collect the
corresponding Flink logs after the tests ran in
[tools/ci/test_controller.sh:128](https://github.com/apache/flink/blob/323c662f19bf2def11c6605f4f73819d92ef0824/tools/ci/test_controller.sh#L128).
Waiting for the timeout doesn't help us for the YARN tests. The stacktraces
we're producing would at the end of a timeout would most likely guide us to the
corresponding `join` call and we would miss the more relevant Flink logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
