dmvk commented on a change in pull request #17160:
URL: https://github.com/apache/flink/pull/17160#discussion_r702957194
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -85,7 +85,15 @@ public Fabric8FlinkKubeClient(
Configuration flinkConfig,
NamespacedKubernetesClient client,
ExecutorService executorService) {
- this.clusterId =
checkNotNull(flinkConfig.getString(KubernetesConfigOptions.CLUSTER_ID));
+ this.clusterId =
Review comment:
`NullPointerException` didn't really feel suitable here as this is
basically a misconfiguration on the user side.
NPE is more suitable for API misuse (something that can be avoided doing
static code analysis).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
