becketqin commented on a change in pull request #17064:
URL: https://github.com/apache/flink/pull/17064#discussion_r703123222
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java
##########
@@ -83,7 +83,7 @@ public static void setup() throws Throwable {
KafkaSourceTestEnv.setup();
try (AdminClient adminClient = KafkaSourceTestEnv.getAdminClient()) {
adminClient.createTopics(
- Collections.singleton(new NewTopic(TOPIC, NUM_SPLITS,
(short) 1)));
+ Collections.singleton(new NewTopic(TOPIC,
KafkaSourceTestEnv.NUM_PARTITIONS, (short) 1)));
Review comment:
Should we override the `getNumSplits()` method here to return
`KafkaSourceTestEnv.NUM_PARTITIONS` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
