[
https://issues.apache.org/jira/browse/FLINK-24185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411105#comment-17411105
]
Chesnay Schepler commented on FLINK-24185:
------------------------------------------
That sounds reasonable but are you sure you compared it with the right NOTICE?
Outside of what was addressed in FLINK-24027, I can't confirm any of the other
issues you have listed. Everything you list as missing is in the notice, the
versions are correct, and (again beyond what was removed in FLINK-24027)
everything that should be removed isn't present.
[aopalliance|https://github.com/apache/flink/blob/release-1.14.0-rc0/flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE#L85]
[airlift|https://github.com/apache/flink/blob/release-1.14.0-rc0/flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE#L33]
[presto|https://github.com/apache/flink/blob/release-1.14.0-rc0/flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE#L21]
> flink-s3-fs-presto bundled dependencies not listed in NOTICE file
> -----------------------------------------------------------------
>
> Key: FLINK-24185
> URL: https://issues.apache.org/jira/browse/FLINK-24185
> Project: Flink
> Issue Type: Bug
> Components: FileSystems
> Affects Versions: 1.14.0
> Reporter: Xintong Song
> Priority: Blocker
> Labels: legal
> Fix For: 1.14.0
>
>
> The following bundled dependencies missing in NOTICE file.
> * aopalliance:aopalliance:1.0
> * com.facebook.airlift:configuration:0.201
> * com.facebook.airlift:log:0.201
> * com.facebook.airlift:stats:0.201
> * com.facebook.presto.hadoop:hadoop-apache2:2.7.3-1
> * com.facebook.presto:presto-common:0.257
> * com.facebook.presto:presto-hive-common:0.257
> * com.facebook.presto:presto-hive-metastore:0.257
> * com.facebook.presto:presto-hive:0.257
> * com.google.inject:guice:4.2.2
> * dnsjava:dnsjava:2.1.7
> * io.airlift:slice:0.38
> * io.airlift:units:1.3
> * org.alluxio:alluxio-shaded-client:2.5.0-3
> * org.hdrhistogram:HdrHistogram:2.1.9
> * org.weakref:jmxutils:1.19
> The following bundled dependencies listed with incorrect version in NOTICE
> file.
> * com.google.guava:guava:26.0-jre
> The following should not be listed in NOTICE file
> * com.google.errorprone:error_prone_annotations:2.2.0
> * com.google.guava:failureaccess:1.0
> * com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
> * com.google.j2objc:j2objc-annotations:1.1
> * commons-lang:commons-lang:2.6
> * org.apache.hadoop.thirdparty:hadoop-shaded-guava:1.1.1
> * org.apache.hadoop.thirdparty:hadoop-shaded-protobuf_3_7:1.1.1
> * org.wildfly.openssl:wildfly-openssl:1.0.7.Final
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
