CrynetLogistics commented on a change in pull request #17068: URL: https://github.com/apache/flink/pull/17068#discussion_r703449902
########## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/ResultFuture.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.base.sink.writer; + +import org.apache.flink.annotation.PublicEvolving; + +import java.util.Collection; + +/** + * The entire request may fail or single request entries that are part of the request may not be + * persisted successfully, eg, because of network issues or service side throttling. All request + * entries that failed with transient failures need to be re-queued with this method so that aren't + * lost and can be retried later. + * + * <p>Request entries that are causing the same error in a reproducible manner, eg, ill-formed + * request entries, must not be re-queued but the error needs to be handled in the logic of {@code + * submitRequestEntries}. Otherwise these request entries will be retried indefinitely, always + * causing the same error. + * + * @param <RequestEntryT> + */ +@PublicEvolving +public interface ResultFuture<RequestEntryT> { Review comment: I agree, especially now that I've found there's a `org.apache.flink.streaming.api.functions.async.ResultFuture` already in the Flink codebase. However I couldn't find any good candidates that has just a `void complete(T failed)` method in the Flink codebase. A search everywhere for `void complete` gave a few options but none perfect... `org.apache.flink.streaming.api.functions.async.ResultFuture` is the closest fit, but has another method `completeExceptionally` which we wouldn't use and would confuse. Perhaps there might be something in the Java library that fits our needs? Or would it be appropriate to just keep and rename this method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
