[
https://issues.apache.org/jira/browse/FLINK-24168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411133#comment-17411133
]
JING ZHANG edited comment on FLINK-24168 at 9/7/21, 12:20 PM:
--------------------------------------------------------------
[~twalthr] Your description about *MATCH_ROWTIME(rowtime)* sounds reasonable.
But I have to admit pass a time attribute may confuse users a bit.
How about *MATCH_ROWTIME_LTZ* directly? The syntax of *MATCH_ROWTIME_LTZ* is
same with *MATCH_ROWTIME* except it's input row time attribute and output type.
We could check in `RelTimeIndicatorConverter` that *MATCH_ROWTIME_LTZ* AND
*MATCH_ROWTIME* should match it's input time attribute. But this solution which
is not so friendly to users because they need choose the right function based
on the input rowtime attribute.
was (Author: qingru zhang):
[~twalthr] Your description about *MATCH_ROWTIME(rowtime)* sounds reasonable.
But I have to admit pass a time attribute may confuse users a bit.
How about *MATCH_ROWTIME_LTZ* directly? The syntax of *MATCH_ROWTIME_LTZ* is
same with *MATCH_ROWTIME* except it's input row time attribute and output type.
We could check in `RelTimeIndicatorConverter` that *MATCH_ROWTIME_LTZ* AND
*MATCH_ROWTIME* should match it's input time attribute. But we leave the
derivation of the row time type to the user in this solution which is not so
friendly to users.
> Rowtime type is not correct for windowTableFunction or OverAggregate follows
> after Match because the output type does not updated after input rowtime
> attribute changed from rowtime to rowtime_ltz
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-24168
> URL: https://issues.apache.org/jira/browse/FLINK-24168
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.14.0
> Reporter: JING ZHANG
> Assignee: JING ZHANG
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Rowtime type is not correct for windowTableFunction or OverAggregate on Match
> because the output type does not updated after input rowtime attribute
> changed from rowtime to rowtime_ltz in `RelTimeIndicator`.
> The bug could be reproduced by the following two cases:
> {code:java}
> @Test
> def testWindowTVFOnMatchRecognizeOnRowtimeLTZ(): Unit = {
> val sqlQuery =
> s"""
> |SELECT
> | *
> |FROM Ticker
> |MATCH_RECOGNIZE (
> | PARTITION BY symbol
> | ORDER BY ts_ltz
> | MEASURES
> | A.price as price,
> | A.tax as tax,
> | MATCH_ROWTIME() as matchRowtime
> | ONE ROW PER MATCH
> | PATTERN (A)
> | DEFINE
> | A AS A.price > 0
> |) AS T
> |""".stripMargin
> val table = util.tableEnv.sqlQuery(sqlQuery)
> util.tableEnv.registerTable("T", table)
> val sqlQuery1 =
> s"""
> |SELECT *
> |FROM TABLE(TUMBLE(TABLE T, DESCRIPTOR(matchRowtime), INTERVAL '3'
> second))
> |""".stripMargin
> util.verifyRelPlanWithType(sqlQuery1)
> }
> @Test
> def testOverWindowOnMatchRecognizeOnRowtimeLTZ(): Unit = {
> val sqlQuery =
> s"""
> |SELECT
> | *
> |FROM Ticker
> |MATCH_RECOGNIZE (
> | PARTITION BY symbol
> | ORDER BY ts_ltz
> | MEASURES
> | A.price as price,
> | A.tax as tax,
> | MATCH_ROWTIME() as matchRowtime
> | ONE ROW PER MATCH
> | PATTERN (A)
> | DEFINE
> | A AS A.price > 0
> |) AS T
> |""".stripMargin
> val table = util.tableEnv.sqlQuery(sqlQuery)
> util.tableEnv.registerTable("T", table)
> val sqlQuery1 =
> """
> |SELECT
> | symbol,
> | price,
> | tax,
> | matchRowtime,
> | SUM(price) OVER (
> | PARTITION BY symbol ORDER BY matchRowtime RANGE UNBOUNDED
> PRECEDING) as price_sum
> |FROM T
> """.stripMargin
> util.verifyRelPlanWithType(sqlQuery1)
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
