syhily commented on pull request #17159: URL: https://github.com/apache/flink/pull/17159#issuecomment-914280245
> The change looks good to me. I verified that passing `0` is the issue. But I'm wondering why we actually run a repeated test here. @syhily why is it necessary to use random numbers here? > > To me, it looks like we could split up this test method into three separate test methods that tests the three cases below range, within range and above range. Each of these tests would only be executed once with a static number. Or am I missing something? 🤔 It's unnecessary to use repeat test, we can just remove it. Pass `0` is the issue, I think we can just remove the random number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
