rkhachatryan commented on a change in pull request #16978:
URL: https://github.com/apache/flink/pull/16978#discussion_r703559146
##########
File path: flink-test-utils-parent/flink-test-utils/pom.xml
##########
@@ -115,6 +115,14 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-statebackend-changelog</artifactId>
+ <version>${project.version}</version>
+ <!-- the dependency should be transitive -->
+ <scope>runtime</scope>
Review comment:
It looks like no strong position was expressed on `runtime` vs `compile`
in that discussion.
To me, `compile` is a bit superflous here as it allows to use backend code
in `flink-test-utils` explicitly;
while for dependants, both `compile` and `runtime`
[result](https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope)
in the same `test` scope.
WDYT?
cc: @zentol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
