curcur commented on a change in pull request #16978:
URL: https://github.com/apache/flink/pull/16978#discussion_r703984449



##########
File path: flink-test-utils-parent/flink-test-utils/pom.xml
##########
@@ -115,6 +115,14 @@ under the License.
                        </exclusions>
                </dependency>
 
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-statebackend-changelog</artifactId>
+            <version>${project.version}</version>
+            <!-- the dependency should be transitive -->
+            <scope>runtime</scope>

Review comment:
       Yes, that makes sense to me. I also think `runtime` is enough if purely 
for transitive dependencies.
   
   But all other dependencies put in `flink-test-utils` are in `compile` level, 
that's why I am asking.
   
   cc @zentol . Could you please double confirm?
   
   I have no strong opinion here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to