SteNicholas commented on a change in pull request #17155:
URL: https://github.com/apache/flink/pull/17155#discussion_r704049843
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AlterTableOptionsOperation.java
##########
@@ -22,15 +22,32 @@
import org.apache.flink.table.catalog.ObjectIdentifier;
import org.apache.flink.table.operations.OperationUtils;
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.Map;
import java.util.stream.Collectors;
-/** Operation to describe a ALTER TABLE .. SET .. statement. */
+/** Operation to describe a ALTER TABLE IF EXISTS .. SET .. statement. */
public class AlterTableOptionsOperation extends AlterTableOperation {
private final CatalogTable catalogTable;
+ private final Map<String, String> tableOptions;
Review comment:
@Airblader , the `CatalogTable` isn't hold only by
`AlterTableOptionsOperation`. Other operations like `AlterTableSchemaOperation`
also hold the `CatalogTable`.
IMO, the converter between the SQL and operation should not pass the
`CatalogTable`. The `CatalogTable` is looked up when calling
`TableEnvironmentImpl#executeInternal`. But the changes could be pushed another
PR to unify updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
