slinkydeveloper commented on a change in pull request #17186:
URL: https://github.com/apache/flink/pull/17186#discussion_r704089572
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java
##########
@@ -46,6 +55,15 @@
public static final InputTypeStrategy CURRENT_WATERMARK =
new CurrentWatermarkInputTypeStrategy();
+ /** Input strategy for {@link BuiltInFunctionDefinitions#JSON_OBJECT}. */
+ public static final InputTypeStrategy JSON_OBJECT =
+ compositeSequence()
+ .argument(symbol(JsonOnNull.class))
+ .finishWithVarying(
+ repeatingSequence(
+
and(logical(LogicalTypeFamily.CHARACTER_STRING), LITERAL),
Review comment:
Perhaps can you add a comment here being explicit about how the
signature of JSON_OBJECT function works and its inference? e.g.:
> JSON_OBJECT takes as input a vararg composed by a sequence of couples of
string keys and any value
Or something like that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
