[ 
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341900#comment-15341900
 ] 

ASF GitHub Bot commented on FLINK-1707:
---------------------------------------

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2053
  
    Hi @joseprupi,
    thanks a lot for this PR.
    
    I have looked through the code and I'm quite worried about its performance 
and scalability. Have you tried it out with any big inputs? We will definitely 
have to get rid of the calls to 'collect()' and try to re-think whether we can 
do without so much state in the auxiliary vertices.
    
    Even though I am quite familiar with the original AP algorithm, I'm not 
sure I understand all the details of the binary AP. Could you maybe create and 
explain a small example, for a small input graph and say 2-3 iterations, and 
show the messages and computations that are required. You can add this to the 
design document. Thanks!


> Add an Affinity Propagation Library Method
> ------------------------------------------
>
>                 Key: FLINK-1707
>                 URL: https://issues.apache.org/jira/browse/FLINK-1707
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Josep RubiĆ³
>            Priority: Minor
>              Labels: requires-design-doc
>         Attachments: Binary_Affinity_Propagation_in_Flink_design_doc.pdf
>
>
> This issue proposes adding the an implementation of the Affinity Propagation 
> algorithm as a Gelly library method and a corresponding example.
> The algorithm is described in paper [1] and a description of a vertex-centric 
> implementation can be found is [2].
> [1]: http://www.psi.toronto.edu/affinitypropagation/FreyDueckScience07.pdf
> [2]: http://event.cwi.nl/grades2014/00-ching-slides.pdf
> Design doc:
> https://docs.google.com/document/d/1QULalzPqMVICi8jRVs3S0n39pell2ZVc7RNemz_SGA4/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to